Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the-x-files-taglines #92

Merged
merged 1 commit into from
Jan 31, 2024
Merged

add the-x-files-taglines #92

merged 1 commit into from
Jan 31, 2024

Conversation

zsz
Copy link
Contributor

@zsz zsz commented Jan 23, 2024

I have made a collection of unique taglines appearing at the beginning of certain episodes of the television series, The X-Files. And thought so it would fit into the list of data files the fortune-mod is distributed with. Or maybe not at all.

@shlomif
Copy link
Owner

shlomif commented Jan 23, 2024

@zsz: hi. thanks! I see these issues:

  1. you didnt add it to https://github.com/shlomif/fortune-mod/blob/master/fortune-mod/CMakeLists.txt#L314 (the CMakeLists.txt) so it wouldnt be installed.

  2. "x-files" isnt mentioned/attributed in the added cookies.

@shlomif
Copy link
Owner

shlomif commented Jan 24, 2024

@zsz : hi. Please address request no. 2,handle

#   Failed test 'the-x-files-taglines failed - Fortune cookie file contains a line longer than 80 characters.'
#   at C:/projects/fortune-mod/fortune-mod/tests/t/check-cookies.t line 45.
# Looks like you failed 1 test of 1.
C:/projects/fortune-mod/fortune-mod/tests/t/check-cookies.t ............. 
1..1
not ok 1 - the-x-files-taglines failed - Fortune cookie file contains a line longer than 80 characters.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
C:/projects/fortune-mod/fortune-mod/tests/t/check-rinutils.t ............ 
1..1

and squash the commits

@zsz zsz changed the title add x-files-taglines add the-x-files-taglines Jan 30, 2024
@zsz
Copy link
Contributor Author

zsz commented Jan 31, 2024

@shlomif

@zsz: hi. thanks! I see these issues:

  1. you didnt add it to https://github.com/shlomif/fortune-mod/blob/master/fortune-mod/CMakeLists.txt#L314 (the CMakeLists.txt) so it wouldnt be installed.

Fixed.

  1. "x-files" isnt mentioned/attributed in the added cookies.

I was wondering what you meant by that... but I have figured it, I guess so. :)

Anyway everything should be fine now, in a single commit (sorry for the force push).

@shlomif shlomif merged commit 8a9a86a into shlomif:master Jan 31, 2024
1 check passed
@shlomif
Copy link
Owner

shlomif commented Jan 31, 2024

@zsz : merged. thanks!

@zsz zsz deleted the add_the_x-files_taglines branch February 1, 2024 14:57
clrpackages pushed a commit to clearlinux-pkgs/fortune-mod that referenced this pull request Jul 10, 2024
…ion 3.22.0

July 2, 2024 (fortune-mod 3.22.0)

	Add the the-x-files-taglines collection.
	shlomif/fortune-mod#92

	Add the -D USE_PCRE=1 option to use the PCRE2 library for regexes.

	GitHub Actions , .act-github , appveyor , cleanups and fixes.

	Remove duplicates.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants