Avoid implicit perl imports - make them explicit.

See: https://perl-begin.org/tutorials/bad-elements/#non_explicitly_imported_symbols . Broke HTML...EscapeHtml !
shlomif · Jul 1, 2020 · aeef477 · aeef477
1 parent 763d5cf
commit aeef477
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 18 deletions.
diff --git a/module/lib/HTML/Widgets/NavMenu.pm b/module/lib/HTML/Widgets/NavMenu.pm
@@ -166,7 +166,7 @@ package HTML::Widgets::NavMenu;
 
 use parent 'HTML::Widgets::NavMenu::Object';
 
-use HTML::Widgets::NavMenu::Url;
+use HTML::Widgets::NavMenu::Url ();
 
 require HTML::Widgets::NavMenu::Iterator::NavMenu;
 require HTML::Widgets::NavMenu::Iterator::SiteMap;

diff --git a/module/lib/HTML/Widgets/NavMenu/EscapeHtml.pm b/module/lib/HTML/Widgets/NavMenu/EscapeHtml.pm
@@ -5,15 +5,15 @@ use warnings;
 
 use parent qw(Exporter);
 
-use vars qw(@EXPORT);
+use vars qw(@EXPORT_OK);
 
 =head1 NAME
 
 HTML::Widgets::NavMenu::EscapeHtml - provides a function to escape HTML.
 
 =head1 SYNOPSIS
 
-    use HTML::Widgets::NavMenu::EscapeHtml;
+    use HTML::Widgets::NavMenu::EscapeHtml qw/ escape_html /;
 
     my $escaped_html = escape_html($html);
 
@@ -23,7 +23,7 @@ Escapes the HTML.
 
 =cut
 
-@EXPORT = (qw(escape_html));
+@EXPORT_OK = (qw(escape_html));
 
 sub escape_html
 {

diff --git a/module/lib/HTML/Widgets/NavMenu/Iterator/Html.pm b/module/lib/HTML/Widgets/NavMenu/Iterator/Html.pm
@@ -28,7 +28,7 @@ For internal use only.
 
 use parent qw(HTML::Widgets::NavMenu::Iterator::Base);
 
-use HTML::Widgets::NavMenu::EscapeHtml;
+use HTML::Widgets::NavMenu::EscapeHtml qw/ escape_html /;
 
 sub _construct_new_item
 {

diff --git a/module/lib/HTML/Widgets/NavMenu/Iterator/JQTreeView.pm b/module/lib/HTML/Widgets/NavMenu/Iterator/JQTreeView.pm
@@ -3,8 +3,7 @@ package HTML::Widgets::NavMenu::Iterator::JQTreeView;
 use strict;
 use warnings;
 
-# For escape_html().
-use HTML::Widgets::NavMenu::EscapeHtml;
+use HTML::Widgets::NavMenu::EscapeHtml qw/ escape_html /;
 
 use parent qw(HTML::Widgets::NavMenu::Iterator::NavMenu);
 

diff --git a/module/lib/HTML/Widgets/NavMenu/Iterator/NavMenu.pm b/module/lib/HTML/Widgets/NavMenu/Iterator/NavMenu.pm
@@ -5,7 +5,7 @@ use warnings;
 
 use parent qw(HTML::Widgets::NavMenu::Iterator::Html);
 
-use HTML::Widgets::NavMenu::EscapeHtml;
+use HTML::Widgets::NavMenu::EscapeHtml qw/ escape_html /;
 
 __PACKAGE__->mk_acc_ref(
     [

diff --git a/module/lib/HTML/Widgets/NavMenu/Object.pm b/module/lib/HTML/Widgets/NavMenu/Object.pm
@@ -3,7 +3,7 @@ package HTML::Widgets::NavMenu::Object;
 use strict;
 use warnings;
 
-use Class::XSAccessor;
+use Class::XSAccessor ();
 
 sub new
 {

diff --git a/module/lib/HTML/Widgets/NavMenu/TagGen.pm b/module/lib/HTML/Widgets/NavMenu/TagGen.pm
@@ -5,7 +5,7 @@ use warnings;
 
 use parent 'HTML::Widgets::NavMenu::Object';
 
-use HTML::Widgets::NavMenu::EscapeHtml;
+use HTML::Widgets::NavMenu::EscapeHtml qw/ escape_html /;
 
 __PACKAGE__->mk_acc_ref( [qw(name attributes)] );
 

diff --git a/module/lib/HTML/Widgets/NavMenu/Tree/Node.pm b/module/lib/HTML/Widgets/NavMenu/Tree/Node.pm
@@ -14,7 +14,7 @@ __PACKAGE__->mk_acc_ref(
     ]
 );
 
-use HTML::Widgets::NavMenu::ExpandVal;
+use HTML::Widgets::NavMenu::ExpandVal ();
 
 =head1 NAME
 

diff --git a/module/t/13escape-html.t b/module/t/13escape-html.t
@@ -1,13 +1,11 @@
-#!/usr/bin/perl -w
-
-use Test::More tests => 9;
+#!/usr/bin/perl
 
 use strict;
+use warnings;
 
-BEGIN
-{
-    use_ok('HTML::Widgets::NavMenu::EscapeHtml');    # TEST
-}
+use Test::More tests => 8;
+
+use HTML::Widgets::NavMenu::EscapeHtml qw/ escape_html /;
 
 {
     # TEST