New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broadcasters: add Typhoon BlueWeather, minor fix for ATC1441 #124

Open

relghuar wants to merge 4 commits into shmuelzon:master from relghuar:master

relghuar commented Jul 20, 2021

add support for BLE broadcaster Typhoon BlueWeather TB002
(http://typhoon.de/Produkte_Typhoon/Gesundheit/BlueWeather.htm)
fix structure format and MAC address encoding for ATC1441
(works with https://github.com/pvvx/ATC_MiThermometer firmware v3.1+)


          broadcasters: add Typhoon BlueWeather, minor fix for ATC1441

78a39ff

- add support for BLE broadcaster Typhoon BlueWeather TB002
  (http://typhoon.de/Produkte_Typhoon/Gesundheit/BlueWeather.htm)
- fix structure format and MAC address encoding for ATC1441
  (works with https://github.com/pvvx/ATC_MiThermometer firmware v3.1+)

Owner

shmuelzon commented Jul 23, 2021

Thank you for the pull request!
The logic itself looks fine but the code style doesn't fit with the rest of the project:

I don't prefix variables/structure fields according to their type
No need to wrap single-line blocks with curly braces
Single space between operands
Defining all variables at the beginning of the block
Snake case

Would you like me to fix the pull request myself instead of adding a comment for each location or would you rather fix it yourself?

relghuar and others added 3 commits

July 26, 2021 19:57


          Merge branch 'shmuelzon:master' into master

e6ba534


          Merge remote-tracking branch 'upstream/master'

07b4301


          Merge remote-tracking branch 'upstream/master'

c7bd441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment