-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release process (release with a manually triggered action) #139
Conversation
Oh something maybe notable in the implementation you might catch: |
- leave the Cargo.toml package version alone :) | ||
- trigger the `tag and publish crate [manual]` action and specify the release increment (major, minor, or patch) | ||
- once the action completes, the Cargo.toml will be updated and the crate will be live on crates.io | ||
- create a release (with title, notes, thanks, etc) and tie it to the tag that was created by the action / new crate version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this also be handled in the action? or maybe having the github release be manual is a good human checkpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I was thinking exactly that the github release is a good human checkpoint, nice to give a shout out to new contributors or provide links or whatev else, also easy to backfill if we forget it or something too. tho, it might be that that kinda stuff could be added after the fact 🤔 lets see how it goes having it be the human checkpoint 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great README and comments as always 💟
This PR adds an action that can be manually triggered to handle bumping the Cargo.toml version, adding a corresponding tag to the repo, and publishing to crates.io. The full proposed process is documented in the RELEASE.md that's been added here too.
Some things I thought about then decided against before settling on this solution:
(There are also a couple fixes for clippy lints that made it in here and some fixes to other errors that showed up in CI)