-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio Group margin is inconsistent with previous versions #1139
Comments
sl.rt.ht/1139 ← easy link Cannot reproduce this in
To quickly switch between versions:
|
I'm also unable to reproduce this in the latest version. https://jsfiddle.net/8bqth46c/ There was a somewhat recent change to Radio Group which removed the fieldset attribute and improved its overall appearance. They stemmed from #965 and were implemented in f03b09a. From what I can tell, everything looks as expected in 2.0.0-beta.88. If you have additional information, feel free to post it and I'll reopen to investigate! |
I was comparing against 63 I think. I do see a left margin of 4px on the fieldset (under sl-radio-group>shadow-root) in the link you gave me. On the prior version we were using, it had a margin of 0px (using the css I posted earlier) Overall, noit a big deal though. |
Fixed in 5f9bbdf. This fix will be available in the next release. |
awesome! thank you! |
Unknown if this is a bug or was intended, but previously sl-radio group had no margin, whereas now it has a left-margin at least.
The underlying css previously came from:
but that is no longer being applied to the form-control part in sl-radio-group.
This shows that the fieldset adds a margin of 4px (at least on chrome)
The text was updated successfully, but these errors were encountered: