Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swipe on carrousels not engaging sub nav/dots #1686

Closed
fuzenco opened this issue Oct 25, 2023 · 2 comments · Fixed by #1748
Closed

Swipe on carrousels not engaging sub nav/dots #1686

fuzenco opened this issue Oct 25, 2023 · 2 comments · Fixed by #1748
Labels
bug Things that aren't working right in the library. help wanted Ready for a contributor to tackle.

Comments

@fuzenco
Copy link

fuzenco commented Oct 25, 2023

on iOS (at least), if you swipe (don’t use the arrows) in the examples on the Carousels component, the dots don’t change to reflect the current active picture. Using the navigation arrows, however, do correctly engage those dots.

https://shoelace.style/components/carousel

iOS 17.0.3
iPhone Pro 14
512 gb
Latest Safari (as per the OS)
@fuzenco fuzenco added the bug Things that aren't working right in the library. label Oct 25, 2023
@claviska claviska added the help wanted Ready for a contributor to tackle. label Oct 26, 2023
@leoluk
Copy link

leoluk commented Oct 29, 2023

Not working in Chrome 118 either:

carousel.mp4

@fuzenco
Copy link
Author

fuzenco commented Oct 29, 2023

Your movie clip seems to show the nav dots working, albeit with a little delay. But as I mentioned, on iOS it doesn't at all.

@leoluk leoluk mentioned this issue Oct 29, 2023
Closed
@ben-brown-domaine ben-brown-domaine mentioned this issue Nov 16, 2023
Closed
@alenaksu alenaksu mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that aren't working right in the library. help wanted Ready for a contributor to tackle.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(carousel): fix issues with safari shoelace-style/shoelace
3 participants
@claviska @fuzenco @leoluk