Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sl-carousel dots do not update on when you swipe on iOS #1725

Closed
ben-brown-domaine opened this issue Nov 16, 2023 · 4 comments · Fixed by #1748
Closed

sl-carousel dots do not update on when you swipe on iOS #1725

ben-brown-domaine opened this issue Nov 16, 2023 · 4 comments · Fixed by #1748
Labels
bug Things that aren't working right in the library. help wanted Ready for a contributor to tackle.

Comments

@ben-brown-domaine
Copy link

Describe the bug

A bug was reported here which was closed but is not fully fixed. The carousel dots do not update on when you swipe on iOS, however they do when you use the next/prev arrow buttons.

To Reproduce

Open https://shoelace.style/components/carousel on either Chrome or Safari on an iPhone and scroll to the version with pagination. Try swiping and you'll see the dots don't update. Try clicking the arrows and you'll see they do, and will scroll multiple slides to a pre-saved index state (looks like the swiping doesn't update an index variable)

Demo

RPReplay_Final1700112968.MP4

Screenshots

See demo video above

Browser / OS

  • OS: iOS
  • Browser: Chrome, Safari
  • Browser version: latest
@ben-brown-domaine ben-brown-domaine added the bug Things that aren't working right in the library. label Nov 16, 2023
@oncode
Copy link

oncode commented Nov 25, 2023

I also have similar problem when swiping to the next slide and then quickly swipping back before the first swipe has finished. The carousel shows 1 as current index but is back at slide 0 (event sl-slide-change doesn't get fired).

Screen.Recording.2023-11-25.at.01.46.19.mp4

@ben-brown-domaine
Copy link
Author

@claviska Want us to debug and create a PR, or will you be able to resolve this?

@claviska claviska added the help wanted Ready for a contributor to tackle. label Nov 28, 2023
@claviska
Copy link
Member

We'd love some help with this if you have the time!

@bcbweb
Copy link

bcbweb commented Nov 30, 2023

@claviska looks like this may already be resolved in PR #1748, still marked as draft though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library. help wanted Ready for a contributor to tackle.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants