-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sl-tooltip
Element's Popup In Beta 80 Being Covered By Other Elements
#854
Comments
This also causes a regression where we were using Please see:
✔️ https://rt.ht/y4 ( |
Further investigation revealed the two issues with
❌ https://rt.ht/y4x/#se=oi ( |
Improved positioning by refactoring the host page DOM tree. ✔️ ⋯
<sl-tooltip id=st slot=handle placement=left hoist>
<style>
⋯
</style>
<flex slot=content t-a=r style=max-width:max-content;padding-block:.4rem>
⋯
</flex>
<span id=sh style=pointer-events:none;opacity:0 aria-hidden=true>x</span>
</sl-tooltip>
⋯ ✔️ ⋯
<sl-tooltip id=st slot=handle placement=left hoist>
<flex slot=content t-a=r style=max-width:max-content;padding-block:.4rem>
<style>
⋯
</style>
⋯
</flex>
<span id=sh style=pointer-events:none;opacity:0 aria-hidden=true>x</span>
</sl-tooltip>
⋯ Can we have a replacement for Discovered and switched to SyncHTML.io is back in good shape now! Thanks a lot everyone ^o^!
Just a quick note, repositioning performance is slightly worse and position tracking is stuttery in Performing the gif in this comment with
(This is very likely a non-issue, just sharing here fyi.) |
Good catch. The z-index should have been applied to the popup, but it was still being applied to the tooltip's body. Fixed in 2372309.
This is a much better approach than relying on |
@Zozman – if you happen to need a fix for this issue before |
Describe the bug
Inside of beta 80 after the
sl-tooltip
refactor, thepopup
part of the tooltip is not always appearing over the rest of the content in a page. In a variety of scenarios it is appearing under other content.Upon looking into it, it seems that the
popup
part of thesl-tooltip
has noz-index
set. In addition, thebody
of thesl-popup
inside thesl-tooltip
does have az-index
set, but it's not enough to get it in front of other content.To Reproduce
Steps to reproduce the behavior:
sl-tooltip
elementsl-card
that will appear where the popup would appearDemo
https://codepen.io/zozman/pen/bGvxvGm?editors=1100
Screenshots
Current behavior
![unknown](https://user-images.githubusercontent.com/1192364/184424498-8970b61a-1a11-44c1-a8e2-efa1a5887523.png)
Missing
![unknown (1)](https://user-images.githubusercontent.com/1192364/184424525-f110fcc6-26b8-47cb-bfd6-516e9b9f579b.png)
z-index
in thepopup
part ofsl-tooltip
z-index
value inside thebody
part of thesl-popup
Browser / OS
104.0.5112.79
2.0.0-beta.80
The text was updated successfully, but these errors were encountered: