You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a dialog's overlay's hide animation takes longer than the dialog's hide animation, the dialog's styles revert once the dialog's animation has finished, but while the overlay is still going. This means the dialog re-appears.
Fixed by applying fill: 'forwards' to the internal animateTo() function. This is a better default than none since most of the time we'll want the component to remain as it was animated.
While the patch in 326816e fixed the issue for dialogs/drawers, it caused issues with tree/tree item where the focus ring was clipped due to the leftover animation styles. 🙈
I reverted that fix and, instead, improved the animation logic in both dialog and drawer to account for different durations. Both components now work as expected, although I would caution users that using a longer animation for overlays may confuse users since it blocks the UI.
Describe the bug
If a dialog's overlay's hide animation takes longer than the dialog's hide animation, the dialog's styles revert once the dialog's animation has finished, but while the overlay is still going. This means the dialog re-appears.
To Reproduce
Steps to reproduce the behavior:
No repl - see code above. I assume the hide animations need something like
Demo
n/a but I could build one if you really need it
Screenshots
n/a
Browser / OS
Additional information
n/a
The text was updated successfully, but these errors were encountered: