Export autoload discover function and support shadow roots #1236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a
discover(this.shadowRoot)
call within a consumer's web component to opt-into autoloading. Otherwise, if someone has built a component which includes a Shoelace component in the component's shadow DOM, autoloading won't work.(Note: this doesn't add a mutation observer, so it's a one-time discovery. Most component shadow trees are pretty stable I imagine, so I think that's fine, but if it feels too much like a potential gotcha, we could consider opting-in to a mutation observer for the tree.)