Merge pull request #1456 from shoes/arrow-dispose

Properly dispose of ArrowPainter Changelog: bugfix
shoes · Jul 15, 2017 · 8ed4455 · 8ed4455
2 parents 3914018 + 6864c79
commit 8ed4455
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/shoes-swt/lib/shoes/swt/arrow_painter.rb b/shoes-swt/lib/shoes/swt/arrow_painter.rb
@@ -52,7 +52,12 @@ def path
         end
       end
 
+      def dispose
+        clear_path
+      end
+
       def clear_path
+        @path.dispose unless @path.nil? || @path.disposed?
         @path = nil
       end
     end

diff --git a/shoes-swt/spec/shoes/swt/arrow_painter_spec.rb b/shoes-swt/spec/shoes/swt/arrow_painter_spec.rb
@@ -35,4 +35,9 @@
     expect(gc).to receive(:fill_path).with(subject.path)
     subject.paint_control(event)
   end
+
+  it "disposes when clearing path" do
+    expect(subject.path).to receive(:dispose)
+    subject.clear_path
+  end
 end