Add rubocop to rake default set #1392
Conversation
Enough folks (including me) trip over this on first pushes, worth putting in the default testing set
|
if we do this, shouldn't we maybe make the otherwise, good ;) |
|
So default rake actually ends up running |
This encourages us to keep the things we test on CI the same as the things people will probably run by default in the project.
|
On further consideration, made a few more tweaks:
|
README.md
Outdated
| @@ -200,7 +200,7 @@ Shoes 4 is developed in a TDD style using RSpec. You should be writing and runni | |||
|
|
|||
| The simplest way to do this is with rake tasks. | |||
|
|
|||
| $ rake spec | |||
| $ rake | |||
There was a problem hiding this comment.
bundle exec! (otherwise packaging specs fail for me)
There was a problem hiding this comment.
It still fails? I thought I'd fixed that.
Either way, I'll update this as my rule is ABB... "Always Be Bundling"
There was a problem hiding this comment.
I'm not sure, maybe you fixed it and I just haven't knowingly tried afterwards ever again :)
| @@ -1,7 +1,6 @@ | |||
| language: ruby | |||
| script: | |||
| - bundle exec rubocop -D | |||
| - bundle exec rake spec:all | |||
| - bundle exec rake | |||
There was a problem hiding this comment.
I think travis runs rake as default but probably without bundle exec or maybe, not sure - also it's better to be explicit. So this is good. I don't know what I'm writing ;P
| task.options << "--display-cop-names" | ||
| end | ||
|
|
||
| task default: :rubocop |
jasonrclark
force-pushed
the
rubocop-in-rake-default
branch
from
1eedfae
to
f65cac2
Compare
Enough folks (including me) trip over this on first pushes, worth putting in the default testing set.