Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support local recording without publish. #1035

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Support local recording without publish. #1035

merged 1 commit into from
Jul 16, 2022

Conversation

shogo4405
Copy link
Owner

@shogo4405 shogo4405 commented Jul 16, 2022 •
edited
Loading

Description & motivation

  • Support local recording without publish.

Bad

rtmpStream.publish("streamName", .localRecord)
/// stop-recording rtmpStream.publish("streamName") or rtmpStream.close()

Good

rtmpStream.startRecording()
/// rtmpStream.stopRecording()

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots:

@shogo4405 shogo4405 added this to the 1.3.0 milestone Jul 16, 2022
@shogo4405 shogo4405 merged commit c37b535 into main Jul 16, 2022
@shogo4405 shogo4405 deleted the feature/local-recordings branch July 16, 2022 08:13
@Goule Goule mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shogo4405