Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stop recording on stop publishing #1041

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Remove stop recording on stop publishing #1041

merged 1 commit into from
Aug 2, 2022

Conversation

Goule
Copy link
Contributor

@Goule Goule commented Aug 1, 2022

Hello,

Since this PR #1035 local recording is not really related with publishing.

This PR let the user decide when the recording should be stopped.

Goal : allow record even on a network cut

@shogo4405
Copy link
Owner

Thank you.

@shogo4405 shogo4405 merged commit bb23ae0 into shogo4405:main Aug 2, 2022
@Goule Goule deleted the stop-recording branch August 2, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants