added init method to fix uninitialsed memory bugs

shogun-toolbox · Jul 18, 2013 · 15b307a · 15b307a
1 parent e542d2b
commit 15b307a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/shogun/ui/GUIPluginEstimate.cpp b/src/shogun/ui/GUIPluginEstimate.cpp
@@ -18,17 +18,32 @@
 
 using namespace shogun;
 
+CGUIPluginEstimate::CGUIPluginEstimate() : CSGObject()
+{
+	init();
+}
+
 CGUIPluginEstimate::CGUIPluginEstimate(CSGInterface* ui_)
-: CSGObject(), ui(ui_), estimator(NULL),
-	pos_pseudo(1e-10), neg_pseudo(1e-10)
+: CSGObject()
 {
+	init();
+
+	ui=ui_;
 }
 
 CGUIPluginEstimate::~CGUIPluginEstimate()
 {
 	SG_UNREF(estimator);
 }
 
+void CGUIPluginEstimate::init()
+{
+	ui=NULL;
+	estimator=NULL;
+	pos_pseudo=1e-10;
+	neg_pseudo=1e-10;
+}
+
 bool CGUIPluginEstimate::new_estimator(float64_t pos, float64_t neg)
 {
 	SG_UNREF(estimator);

diff --git a/src/shogun/ui/GUIPluginEstimate.h b/src/shogun/ui/GUIPluginEstimate.h
@@ -27,7 +27,7 @@ class CGUIPluginEstimate : public CSGObject
 
 	public:
 		/** constructor */
-		CGUIPluginEstimate() {};
+		CGUIPluginEstimate();
 		/** constructor
 		 * @param interface
 		 */
@@ -65,6 +65,9 @@ class CGUIPluginEstimate : public CSGObject
 		/** @return object name */
 		virtual const char* get_name() const { return "GUIPluginEstimate"; }
 
+	private:
+		void init();
+
 	protected:
 		/** ui */
 		CSGInterface* ui;