Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta example when ´-DENABLE_TESTING=OFF` #3553

Closed
karlnapf opened this issue Nov 18, 2016 · 3 comments
Closed

Fix meta example when ´-DENABLE_TESTING=OFF` #3553

karlnapf opened this issue Nov 18, 2016 · 3 comments

Comments

@karlnapf
Copy link
Member

karlnapf commented Nov 18, 2016

Since the WrappedObjectArray class is guarded and only available when testing is turned on, the meta examples which explicitly import that class will not compile (java, cpp).

Solution:
If variable storing is turned off in meta example generator.py (storeVars or so), then the includes for WrappedObjectArray also have to be omitted.

Nice non trivial entrance task and crucial for any further release

@karlnapf
Copy link
Member Author

For now, the workaround is to compile Shogun with the cmake siwtch -DENABLE_TESTING

@IOcodegeass
Copy link
Contributor

Yes this workaround worked for cpp interface.
Just by compiling using cmake switch -DJavaModular=ON -DENABLE_TESTING=ON ..

geektoni added a commit to geektoni/shogun that referenced this issue Jan 29, 2017
geektoni added a commit to geektoni/shogun that referenced this issue Jan 29, 2017
geektoni added a commit to geektoni/shogun that referenced this issue Jan 29, 2017
@vigsterkr vigsterkr modified the milestones: Shogun 5.1, Shogun 6.0 Mar 15, 2017
@vigsterkr vigsterkr modified the milestones: Shogun 6.1.0, Shogun 6.2.0 Dec 14, 2017
@sorig
Copy link
Member

sorig commented Dec 16, 2017

@karlnapf close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants