Enable meta examples when ENABLE_TESTING is OFF.

[geektoni]

Resolve issue #3553

[karlnapf]

yes I think I like this

[karlnapf]

maybe you can put that to the place where you set the flags rather than down here?
Also, the indentation is a bit weird

[karlnapf]

indentation not respecting the previous one, makes reviewing much harder for me btw

[karlnapf]

This is not the solution that I mentioned in #3553
Can you explain what you are doing here? Not 100% sure I get what you do ... build still passes though so it seems ok

Also, the warning thing with the flag, could you put that into another patch to separate concerns here?

[geektoni]

Hi @karlnapf,
Basically, since the WrappedObjectArray class is guarded and cannot be used when we are not testing the meta examples, I decided to prevent the inclusion of WrappedObjectArray when we are generating the meta examples.

The generator.py take a --store-vars flag that, if used, inserts into the meta example the code to include WrappedObjectArray.

The patch behaviour is:

• If ENABLE_TESTING is OFF, then we don't use the --store-vars flag and no WrappedObjectArray code is added;
• If ENABLE_TESTING is ON, then we do use the flag and the meta examples code will have the library;

I thought this was the best approach to solve this problem and I understood this was the way to proceed when I read the issue you made, but probably I didn't catch your idea, my bad :).

Secondly, I wouldn't like to split the unused variable warnings into another patch because we have unused variable warning only when we produce meta example code that has not WrappedObjectArray. If I do that we will have two patches that rely one on the other, and if this is a wrong way to fix the issue the unused variable warning patch will be of little use.

However, if you prefer to have two separate patch I will gladly create another one. :)

By the way, I moved the unused variable warning and its message close together (since it is more logical as you pointed out), but I don't understand why it shows that bad indentation (I am using tab characters tabsize 4 as specified by yours developer guide).

UPDATE 13/02/2014: I had to move the unused variable warning message to its previous location because it was behaving too verbosely (see this: http://pastebin.com/MF5RDjce).

[karlnapf]

Thanks for the good explanation :) I agree with the variable stuff. I should have realised this but I think I looked at this on my phone...

Very nice work! Merging!