Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for shogun::memcpy #3700

Closed
lambday opened this issue Mar 15, 2017 · 1 comment
Closed

Refactoring for shogun::memcpy #3700

lambday opened this issue Mar 15, 2017 · 1 comment

Comments

@lambday
Copy link
Member

lambday commented Mar 15, 2017

We recently introduced a wrapper shogun::memcpy in shogun/lib/memory.h to be used instead of memcpy calls in Shogun. This method in turn calls std::memcpy as of now. But the goal was to be able to change this to a different implementation later, if possible, that instantly applies Shogun-wise without touching the rest of Shogun.

So, the task is to replace all existing memcpy calls with this newly introduced shogun::memcpy. However, in order to avoid possible errors due to namespaces, we'd like to rename our wrapper method to sg_memcpy first.

Very simple find/sed task for on boarders :)

radsn23 added a commit to radsn23/shogun that referenced this issue Mar 15, 2017
Renamed ‘memcpy’ wrapper to sg_memcpy, changed ‘std::memcpy’ to
‘shogun::memcpy’ using sed.
@radsn23 radsn23 mentioned this issue Mar 15, 2017
@lambday
Copy link
Member Author

lambday commented Mar 20, 2017

Done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant