Sg memcpy #3709

radsn23 · 2017-03-15T17:51:32Z

Fix issue #3700
f269f25

Renamed ‘memcpy’ wrapper to sg_memcpy, changed ‘std::memcpy’ to ‘shogun::memcpy’ using sed.

karlnapf · 2017-03-15T17:58:23Z

Pls dont open and close PRs, creates a lot of junk email. Thanks!

lambday · 2017-03-15T17:59:24Z

src/shogun/lib/memory.h

 {
-	return std::memcpy(static_cast<void*>(dest), static_cast<const void*>(src), count);
+	return shogun::memcpy(static_cast<void*>(dest), static_cast<const void*>(src), count);


Hey there. I'm afraid I didn't make the task clear enough :)

We want to rename this memcpy to sg_memcpy (which you did) that in turn calls std::memcpy just as before (i.e., don't make it call shogun::memcpy inside - that won't exist anymore once you rename it)

We want all existing memcpy uses in Shogun to use this newly added sg_memcpy instead.

See what I mean?

radsn23 added 2 commits March 16, 2017 01:45

Fix issue shogun-toolbox#3700

f269f25

Renamed ‘memcpy’ wrapper to sg_memcpy, changed ‘std::memcpy’ to ‘shogun::memcpy’ using sed.

Merge remote-tracking branch 'shogun-toolbox/develop' into sg_memcpy

92b678d

radsn23 closed this Mar 15, 2017

lambday reviewed Mar 15, 2017

View reviewed changes

radsn23 deleted the sg_memcpy branch March 19, 2017 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sg memcpy #3709

Sg memcpy #3709

radsn23 commented Mar 15, 2017

karlnapf commented Mar 15, 2017

lambday Mar 15, 2017

Sg memcpy #3709

Sg memcpy #3709

Conversation

radsn23 commented Mar 15, 2017

karlnapf commented Mar 15, 2017

lambday Mar 15, 2017

Choose a reason for hiding this comment