Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use_reference_counting option #3788

Closed
iglesias opened this issue Apr 25, 2017 · 2 comments
Closed

Drop use_reference_counting option #3788

iglesias opened this issue Apr 25, 2017 · 2 comments
Labels
Tag: Cleanup Type: Bugfixing

Comments

@iglesias
Copy link
Collaborator

Why to remove it?

  • Some tests break when it is off.
  • We have to guard the code any time we need to call ref_count, ref, or unref in a csgobject directly.

Why to keep it?

  • The only reason I can think of why this option exists is to improve "efficiency" (and introducing leaks).
  • Other?

ps. bugfixing label because this will fix the tests that are failing nightly_none.
@karlnapf
Copy link
Member

Remove!
As well as all other switches of nightly none....

iglesias added a commit to iglesias/shogun that referenced this issue Apr 27, 2017
@iglesias
Remove USE_REFERENCE_COUNTING configuration option shogun-toolbox#3788.
ba3d08e
iglesias added a commit to iglesias/shogun that referenced this issue Apr 27, 2017
@iglesias
Remove USE_REFERENCE_COUNTING configuration option shogun-toolbox#3788.
94f0a5b
iglesias added a commit that referenced this issue Apr 28, 2017
@iglesias
Remove USE_REFERENCE_COUNTING configuration option #3788.
3560969
@karlnapf
Copy link
Member

Done in 3560969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tag: Cleanup Type: Bugfixing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlnapf @iglesias