Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematically test all iterative methods #3889

Closed
karlnapf opened this issue Jun 30, 2017 · 7 comments
Closed

Systematically test all iterative methods #3889

karlnapf opened this issue Jun 30, 2017 · 7 comments

Comments

@karlnapf
Copy link
Member

All models that are trained iteratively should

  • have a progress bar (add to missing ones)
  • have early stopping implemented (with working predictions afterwards) (unit test)
  • should give a warning when not converged (unit test), not fail.
  • Have the option to "continue" training more, if that makes sense (if not converged, or early stopped) (unit test)

This is a mix of automatic unit testing, API updates, and bug-fixes in the methods

Example: ICA methods, @geektoni knows all the other models

@geektoni @micmn maybe you can address a few of those

@karlnapf
Copy link
Member Author

example for warning rather than error message #3885

@vrishank97
Copy link

I'd like to take this up as my first contribution here. What all counts as an iterative method?

@karlnapf
Copy link
Member Author

Everything where the main training method is a big loop with a stopping condition based on iterations and/or tolerance

@vrishank97
Copy link

Would something like the perceptron model also require a progress bar (upto max iters)?

@karlnapf
Copy link
Member Author

no, as we don't know how long it will run

@sunalbert
Copy link
Contributor

Hi, @karlnapf , sorry to disturb you again. I am working on adding progress bar to CRBM. Is there any standard code/template I can follow to test the whether the progress bar works well?

@karlnapf
Copy link
Member Author

karlnapf commented Apr 3, 2018

check git grep progress(range to find the places it is used and how

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants