add progress bar to RBM fix #3889 #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, lets wait for the CI. |
geektoni
reviewed
Apr 3, 2018
src/shogun/neuralnets/RBM.cpp
Outdated
| @@ -136,6 +137,9 @@ void CRBM::train(CDenseFeatures<float64_t>* features) | |||
| buffer = SGMatrix<float64_t>(m_num_hidden, m_batch_size); | |||
|
|
|||
| int32_t counter = 0; | |||
|
|
|||
| auto pb = progress(range(0, max_num_epochs)); | |||
|
|
|||
| for (int32_t i=0; i<max_num_epochs; i++) | |||
There was a problem hiding this comment.
You could have used the compact version here, instead of the pb.print_progress/complete methods :) namely:
for (auto i : progress(range(0, max_num_epochs)))
There was a problem hiding this comment.
Ok, thanks. I will modify the code.
|
Ill merge once CI is green |
|
The CI fails again. How can I fix the error "The job exceeded the maximum time limit for jobs, and has been terminated" |
|
Unfortunately, that error is not something you can fix from your side because it is caused by Travis itself. However, this PR should be mergeable since all the other builds are green. |
|
Ok, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add progress bar to RBM algorithm