New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in Lua interface example #4038
Comments
Whoops, indeed! This is a lovely entrance task for those try to get involved in Shogun. |
The R command also is not rendered properly, so that needs a mini fix as well |
I want to take up and work on this issue. |
do it :) |
Well, do I need to create a separate issue and create different PR for R command? |
Nope, just fixing typos can be done in a single PR which consists of 1-2 lines |
prashanthduvvada
added a commit
to prashanthduvvada/shogun
that referenced
this issue
Dec 26, 2017
Made the required changes
karlnapf
pushed a commit
that referenced
this issue
Dec 26, 2017
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this issue
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Lua example here https://github.com/shogun-toolbox/shogun/blob/develop/doc/readme/INTERFACES.md appears to have a typo; the call to run the example should probably be closer to what is generated by https://github.com/shogun-toolbox/shogun/blob/develop/examples/meta/lua/CMakeLists.txt (I don't run lua locally, otherwise would submit a PR)
The text was updated successfully, but these errors were encountered: