Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Lua interface example #4038

Open
jgoldfar opened this issue Dec 21, 2017 · 6 comments
Open

Typo in Lua interface example #4038

jgoldfar opened this issue Dec 21, 2017 · 6 comments

Comments

@jgoldfar
Copy link

The Lua example here https://github.com/shogun-toolbox/shogun/blob/develop/doc/readme/INTERFACES.md appears to have a typo; the call to run the example should probably be closer to what is generated by https://github.com/shogun-toolbox/shogun/blob/develop/examples/meta/lua/CMakeLists.txt (I don't run lua locally, otherwise would submit a PR)

@karlnapf
Copy link
Member

Whoops, indeed!
Thanks for reporting.

This is a lovely entrance task for those try to get involved in Shogun.

@karlnapf
Copy link
Member

The R command also is not rendered properly, so that needs a mini fix as well

@prashanthduvvada
Copy link
Contributor

I want to take up and work on this issue.

@karlnapf
Copy link
Member

do it :)

@prashanthduvvada
Copy link
Contributor

Well, do I need to create a separate issue and create different PR for R command?

@karlnapf
Copy link
Member

Nope, just fixing typos can be done in a single PR which consists of 1-2 lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants