Updated example command for lua and R: Fix for issue #4038 #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did the following things 1) Fixed the lua's example command 2) Fixed R example command's intendation
vigsterkr
reviewed
Dec 26, 2017
doc/readme/INTERFACES.md
Outdated
| @@ -69,6 +69,7 @@ This needs `shogun.R` to be visible, which is either in `path/to/build/src/inter | |||
| export R_LIBS_USER="path/to/shogun.R:$R_LIBS_USER" | |||
|
|
|||
| Running an example: | |||
|
|
|||
| R --no-restore --no-save --no-readline --slave -f path/to/r_example.rb | |||
There was a problem hiding this comment.
there's a typo here as well, i.e. it should be path/to/r_example.r and not path/to/r_example.rb (there's an extra b on the end)
|
Will change |
Made the required changes
Codecov Report
@@ Coverage Diff @@
## develop #4053 +/- ##
===========================================
+ Coverage 56.55% 56.55% +<.01%
===========================================
Files 1331 1331
Lines 92773 92773
===========================================
+ Hits 52465 52467 +2
+ Misses 40308 40306 -2
Continue to review full report at Codecov.
|
karlnapf
approved these changes
Dec 26, 2017
|
Thanks @karlnapf |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did the following things as per #4038