Made refcounting in SGObject use the RefCount class [WIP] #1406
Conversation
| SG_GCDEBUG("ref() refcount %ld obj %s (%p) increased\n", count, this->get_name(), this) | ||
| return m_refcount; | ||
| return m_refcount->ref_count(); |
There was a problem hiding this comment.
Before, the m_refcount was returned instead of count, which led me to think that it should return the current ref_count ( since m_refcount could have been increased/decreased again after the unlock() ), instead of the (variable) count in this method.
This is the expected behavior, correct?
There was a problem hiding this comment.
m_refcount was an integer with the refcount so yes that should do it. btw you could consider keeping the refcount as part of the object (not a pointer).
|
Updated and added a stress test unit case that under helgrind produced no errors. Probably further testing is required. Additionally, I think it should be discussed whether copied objects should always share the RefCount object or not, as well as to select the starting value of the refcounter (since we only delete on ==0 atm) and you mentioned something about SWIG adding + 1? |
Made refcounting in SGObject use the RefCount class
Unref also remains to be discussed