-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
users can disable the gradient computation #2835
Conversation
@karlnapf |
Changes Unknown when pulling 6e43637 on yorkerlin:inference into * on shogun-toolbox:develop*. |
@@ -75,6 +75,7 @@ void CInferenceMethod::init() | |||
SG_ADD((CSGObject**)&m_mean, "mean_function", "Mean function", MS_AVAILABLE); | |||
SG_ADD((CSGObject**)&m_labels, "labels", "Labels", MS_NOT_AVAILABLE); | |||
SG_ADD((CSGObject**)&m_features, "features", "Features", MS_NOT_AVAILABLE); | |||
SG_ADD(&m_is_compute_gradients, "is_compute_gradients", "whether gradients are computed", MS_NOT_AVAILABLE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the field called "is" ?
what about "m_compute_gradients?
Minor "Whether gradients are computed" (capital W)
It is good to have this option.
Thoughts? |
for lazy update, it is related to this the fact is in SGObject for lazy update, I need |
Ok, please do the lazy one after the bugfix. We dont want users to need to be explicit about this |
No description provided.