users can disable the gradient computation [new] #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -254,6 +254,7 @@ void CSGObject::update_parameter_hash() | |||
| uint32_t carry=0; | |||
| uint32_t length=0; | |||
|
|
|||
| m_hash=0; | |||
There was a problem hiding this comment.
please send a seperate PR for this fix, and add unit tests that make sure the rationale is explicit
|
How does this work from the user perspective now? |
|
ref |
|
@karlnapf
are required |
|
Cool thats perfpect. As said, could you send a seperate PR with the bugfix and a unit test for the hash behavious? thanks! |
|
@karlnapf |
|
Great thanks! |
karlnapf
added a commit
that referenced
this pull request
May 16, 2015
users can disable the gradient computation [new]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karlnapf
take a look at this