Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up regression notebook #3047

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

sanuj
Copy link
Contributor

@sanuj sanuj commented Mar 7, 2016

Removes a deprecated warning and three errors. This notebook has been saved for version 4 of ipython since i have that installed on my laptop.

@karlnapf I wanted to confirm whether version 4 is ok for shogun or should i stick to version 3 (that shogun uses currently) before I send anymore notebook related PRs.

@sanuj
Copy link
Contributor Author

sanuj commented Mar 7, 2016

Got this error at 3 different places. The fix was to make c take an array whose length was equal to number of training points that were being plotted.

Also changed set_color_cycle to set_prop_cycle to fix the following deprecated warning.

/usr/local/lib/python2.7/dist-packages/matplotlib/cbook.py:137: MatplotlibDeprecationWarning: The set_color_cycle attribute was deprecated in version 1.5. Use set_prop_cycle instead.
  warnings.warn(message, mplDeprecation, stacklevel=1)

The notebook is rendered weirdly on Github. It looks fine when I run it locally.

@karlnapf
Copy link
Member

karlnapf commented Mar 7, 2016

@vigsterkr what ipython is on the buildbot?

@vigsterkr
Copy link
Member

3.1.0

@karlnapf
Copy link
Member

karlnapf commented Mar 7, 2016

If we have the new version (which we should) I am up for merging this....

@karlnapf
Copy link
Member

karlnapf commented Mar 7, 2016

can update?

@vigsterkr
Copy link
Member

yes, to which version?

@sanuj
Copy link
Contributor Author

sanuj commented Mar 7, 2016

@vigsterkr
Copy link
Member

so we want 4.x?

@vigsterkr
Copy link
Member

just upgraded to ipython (4.1.2), but we dont have buildbot so wont be able to test notebook related things until we dont resurrect buildbot

@karlnapf
Copy link
Member

karlnapf commented Mar 7, 2016

Nice thanks, I will merge

karlnapf added a commit that referenced this pull request Mar 7, 2016
@karlnapf karlnapf merged commit 5fda3b4 into shogun-toolbox:develop Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants