-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta language: Modified parser to handle SGVector, SGMatrix accessing #3285
Conversation
@@ -1,3 +0,0 @@ | |||
generator/parsetab.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Cool thanks for that. Once we have a json update, I can take over |
8e87352
to
9764e7c
Compare
@karlnapf ready for review when travis has finished These changes include:
Does not include:
|
Here is a test file that I used. Would be nice to get a meta example using these features merged, so we can test all the languages. |
"CharVector": "$name = np.zeros( ($arguments), dtype='|S1')", | ||
"ByteVector": "$name = np.zeros( ($arguments), dtype='uint8')", | ||
"WordVector": "$name = np.zeros( ($arguments), dtype='uint16')", | ||
"ShortVector": "$name = np.zeros( ($arguments), dtype=???????)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't import some of these from the Python interface, so can't check what type they should have. Maybe they just need to be removed?
2f0d406
to
fe0edfc
Compare
- Modify meta language to handle SGVector, SGMatrix accessing. - Fix line number counting bug - Improve error messages from translation errors - Translate.py: Decouple dependency extraction and translation - Translate.py: Decouple injection of variable storing code and translation - Fix most PEP8 violations - Add support for custom initialisation of SGVector/Matrix in target languages e.g. (python) initialisation of numpy arrays rather than SWIG wrappers - Remove legacy file get_type_list.sh
Let me know when the vector / matrix access stuff is there. |
@karlnapf All green. Ready to merge |
The test file has both a vector and a matrix :) |
Great thanks @OXPHOS this will soon allow for vector element access in meta examples, after I added some minor adjustments |
@OXPHOS you should be able to use something like this now Can you try? |
keep in mind to remove old parser output |
Meta language: Modified parser to handle SGVector, SGMatrix accessing
WIP