pull cloning all parameterers out to a seperate method #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
force-pushed
the
feature/clone_refactor
branch
4 times, most recently
from
5b9e152
to
a57b7c7
Compare
lkuchenb
reviewed
Feb 20, 2017
src/shogun/base/SGObject.cpp
Outdated
| REQUIRE(!strcmp(other->get_name(), get_name()), | ||
| "Name of provided instance (%s) must match this instance (%d).\n", | ||
| other->get_name(), get_name()); | ||
|
|
lkuchenb
reviewed
Feb 20, 2017
src/shogun/base/SGObject.cpp
Outdated
|
|
||
| SG_DEBUG("leaving %s::clone(): Clone successful\n", get_name()); | ||
| return copy; | ||
|
|
lkuchenb
reviewed
Feb 20, 2017
src/shogun/base/SGObject.cpp
Outdated
| REQUIRE(other->m_parameters->get_num_parameters() == m_parameters->get_num_parameters(), | ||
| "Number of parameters of provided instance (%d) must match this instance (%d).\n", | ||
| other->m_parameters->get_num_parameters(), m_parameters->get_num_parameters()); | ||
| REQUIRE(!strcmp(other->get_name(), get_name()), |
There was a problem hiding this comment.
Wrong format specifier %d
karlnapf
force-pushed
the
feature/clone_refactor
branch
2 times, most recently
from
0f47b04
to
4845441
Compare
karlnapf
force-pushed
the
feature/clone_refactor
branch
from
4845441
to
1f83d99
Compare
|
Travis error unrelated, merging |
karasikov
pushed a commit
to karasikov/shogun
that referenced
this pull request
Apr 15, 2017
…factor pull cloning all parameterers out to a seperate method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.