Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintegrate parallel crossvalidation #3660

Merged

Conversation

lkuchenb
Copy link
Contributor

Would be great to see this back in develop

@vigsterkr
Copy link
Member

@lkuchenb cool! let's see what CI says about this :)

@karlnapf
Copy link
Member

so travis didnt complain more than the current broken things
@vigsterkr iirc the bugs in the parallel xvalidation with clone were caused by parallel issues that were fixed?

@vigsterkr
Copy link
Member

@karlnapf i think it was completely other stuff :) only thing we need to test that i vividly remember that for some in one of the ipython notebooks the CV stuff was failing with this .... so somebody should try to run the notebook using this patch (imo there's a CV notebook, or?)

@vigsterkr
Copy link
Member

@lkuchenb i'll try to finish up the input parser story in cpp11 branch so we can merge and then we can rebase this one to be sure about the MSVC et.al.

@karlnapf
Copy link
Member

There is one
@lkuchenb wanna have a go at that?

@lkuchenb lkuchenb force-pushed the feature/parallel_xval_reintegration branch from c0a3a62 to 6eb1b2a Compare February 28, 2017 13:30
@vigsterkr
Copy link
Member

wooohooo, getting a parallel CV, how awesome is this in 2017! 💃

@vigsterkr vigsterkr merged commit 277aeb7 into shogun-toolbox:develop Feb 28, 2017
@lkuchenb lkuchenb deleted the feature/parallel_xval_reintegration branch February 28, 2017 16:16
@lkuchenb lkuchenb restored the feature/parallel_xval_reintegration branch February 28, 2017 16:30
@karlnapf
Copy link
Member

karlnapf commented Mar 1, 2017

Next step -- don't clone the fucking data. This is madness in 2017 !!!

karasikov pushed a commit to karasikov/shogun that referenced this pull request Apr 15, 2017
…_xval_reintegration

Reintegrate parallel crossvalidation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants