Fix Issue #4028: Fix ROC Evaluation Messages #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the ROC Evaluation messages to the message format described in the issue.
karlnapf
reviewed
Dec 23, 2017
| @@ -19,8 +19,10 @@ CROCEvaluation::~CROCEvaluation() | |||
|
|
|||
| float64_t CROCEvaluation::evaluate(CLabels* predicted, CLabels* ground_truth) | |||
| { | |||
| REQUIRE(predicted->get_label_type()==LT_BINARY, "ROC evalution requires binary labels."); | |||
| REQUIRE(ground_truth->get_label_type()==LT_BINARY, "ROC evalution requires binary labels."); | |||
| REQUIRE(predicted->get_label_type()==LT_BINARY, "Given predicted labels (%d) must be binary (%d).", | |||
There was a problem hiding this comment.
great thanks!
One thing. If one of the provided pointers is NULL ,this segfaults.
So you additionally need something like this for both arguments
REQUIRE(predicted, "No predicted labels provided\n.")
There was a problem hiding this comment.
Also, you are missing a "\n" at the end of the error msg
|
Thanks! Welcome to Shogun! :) |
karlnapf
reviewed
Dec 23, 2017
| REQUIRE(predicted->get_label_type()==LT_BINARY, "ROC evalution requires binary labels."); | ||
| REQUIRE(ground_truth->get_label_type()==LT_BINARY, "ROC evalution requires binary labels."); | ||
| REQUIRE(predicted, "No predicted labels provided.\n"); | ||
| REQUIRE(ground_truth, "No ground_truth labels provided.\n"); |
|
Ace thanks! One last thing (apart from my comment). Could you fix that? We recently are trying to get a more consistent style in |
karlnapf
reviewed
Dec 23, 2017
| REQUIRE(ground_truth, "No ground_truth labels provided.\n"); | ||
| REQUIRE(predicted->get_label_type()==LT_BINARY, "Given predicted labels (%d) must be binary (%d).\n", | ||
| predicted->get_label_type(), LT_BINARY); | ||
| REQUIRE(ground_truth->get_label_type()==LT_BINARY, "Given ground_truth labels (%d) must be binary (%d).\n", |
|
lovely, thanks! :) |
ktiefe
pushed a commit
to ktiefe/shogun
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the ROC Evaluation messages to the message format
described in the issue.