Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #4028: Fix ROC Evaluation Messages #4042

Merged
merged 3 commits into from
Dec 23, 2017
Merged

Fix Issue #4028: Fix ROC Evaluation Messages #4042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b019ec2
Fix Issue 4028: Fix ROC Evaluation Messages
ckousik Dec 23, 2017
ba41500
ROCEvaluation: require label parameters to be not null
ckousik Dec 23, 2017
d0a57cf
Fixed style checker complaints
ckousik Dec 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/shogun/evaluation/ROCEvaluation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,16 @@ CROCEvaluation::~CROCEvaluation()

float64_t CROCEvaluation::evaluate(CLabels* predicted, CLabels* ground_truth)
{
REQUIRE(predicted->get_label_type()==LT_BINARY, "ROC evalution requires binary labels.");
REQUIRE(ground_truth->get_label_type()==LT_BINARY, "ROC evalution requires binary labels.");
REQUIRE(predicted, "No predicted labels provided.\n");
REQUIRE(ground_truth, "No ground truth labels provided.\n");
REQUIRE(
predicted->get_label_type() == LT_BINARY,
"Given predicted labels (%d) must be binary (%d).\n",
predicted->get_label_type(), LT_BINARY);
REQUIRE(
ground_truth->get_label_type() == LT_BINARY,
"Given ground truth labels (%d) must be binary (%d).\n",
ground_truth->get_label_type(), LT_BINARY);

return evaluate_roc((CBinaryLabels*)predicted,(CBinaryLabels*)ground_truth);
}
Expand Down