kwargs ~works~ for objects ~already~ #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
force-pushed
the
develop
branch
2 times, most recently
from
a365110
to
0838b75
Compare
karlnapf
commented
Feb 6, 2018
examples/meta/src/meta_api/kwargs.sg
Outdated
|
|
||
| # The following line fails in Python because of a bool literal issue | ||
| #GaussianKernel k2(log_width=14.0, lhs_equals_rhs=True) | ||
| Kernel k = kernel("GaussianKernel") |
There was a problem hiding this comment.
floats still don't work in octave...
|
@lisitsyn works with cpp, python, java, octave on my machine |
karlnapf
commented
Feb 6, 2018
| @@ -22,17 +22,14 @@ | |||
| # This also fails (keywords not allowed outside initialisation variables) | |||
| #kernel_factory("GaussianKernel", a=glob_fun(ordinary_argument)) | |||
|
|
|||
| # doesnt work in ruby (TODO, don't allow in meta grammar) | |||
There was a problem hiding this comment.
@sorig we will need to block this, ruby doesn't like it
There was a problem hiding this comment.
What does ruby say? I can disable nested global calls, but that may disable some nested calls that are actually useful.
karlnapf
commented
Feb 6, 2018
src/shogun/base/SGObject.cpp
Outdated
| if (has(Tag<numeric_t>(name))) \ | ||
| put(Tag<numeric_t>(name), value); \ | ||
| PUT_DEFINE_CHECK_AND_CAST(int32_t) \ | ||
| PUT_DEFINE_CHECK_AND_CAST(float32_t) \ |
There was a problem hiding this comment.
@lisitsyn since it is only octave that cannot decide between float and int, maybe some of this could be done in swig....though I don't know how that would work....
There was a problem hiding this comment.
karlnapf
changed the title
karlnapf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.