Switch translation of ruby function calls to allow nested calls #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karlnapf just seeing if this passes. May solve the issue you were seeing |
|
Just merged #4154 if you wanna rebase |
|
You will need to test that, I removed the nested call in the |
sorig
force-pushed
the
meta_ruby_method_call_fix
branch
from
2656f50
to
3e3b166
Compare
|
Just rebased and added the test |
karlnapf
reviewed
Feb 7, 2018
|
|
||
| # Real example | ||
| # ------------ | ||
|
|
||
| Kernel k = kernel("GaussianKernel", log_width=2.0) | ||
| KernelMachine svm = kernel_machine("LibSVM", C1=1.1, kernel=k) | ||
|
|
||
| KernelMachine svm2 = kernel_machine("LibSVM", kernel=kernel("GaussianKernel")) |
There was a problem hiding this comment.
can also put the scalars in there :) we have some hackery that covers it now
|
Thanks for the quick fix! :) |
|
Seems like ruby likes you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with ruby in #4154