Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory for the ParameterObservers. #4557

Merged
merged 42 commits into from
Apr 18, 2019
Merged

Add factory for the ParameterObservers. #4557

merged 42 commits into from
Apr 18, 2019

Commits on Apr 18, 2019

  1. Add factory for the ParameterObservers. 

    * Rename ParameterObserverInterface to ParameterObserver for consistency;
* Make ParameterObserver inherith from SGObject;
* Convert usages in the meta examples;
* Split on_next into on_next and on_next_impl;
* Add more methods to ParameverObserver to get a single observation;
* Refactor ParameterObserverCV;
* Fix SWIG interfaces;
* Fix format;
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    7cf6ee5 View commit details
    Browse the repository at this point in the history

  2. Modify get_observation() method in order to work with the interfaces. 

    * Add get_observations() method which outputs a vector of observation
* given a name, casted by a user type;
* Add SWIG code to ensure correct translation of the templates;
* Update cross validation meta example;
* Fix cpp meta examples translation by adding the correct conversion from
  get_CV_storage to the get_observation method;
* Fix unit tests.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    2ea71a5 View commit details
    Browse the repository at this point in the history

  3. Fix linking issues within ParameterObserver.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    bdb8fef View commit details
    Browse the repository at this point in the history

  4. Fix ParameterObserver to work with the new ObservedValueTemplated. 

    * Remove wrong call to m_observations inside ParameterObserverCV.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    846165c View commit details
    Browse the repository at this point in the history

  5. Fix MKL with CV example. 

    * Fix ParameterObserverCV unittest.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    3091b70 View commit details
    Browse the repository at this point in the history

  6. Remove previous set SWIG hacks for the parameter observers.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    95fb7e0 View commit details
    Browse the repository at this point in the history

  7. Fix issue inside ParameterObserver.i

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    af6f861 View commit details
    Browse the repository at this point in the history

  8. Fix undocumented python meta examples.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    00b72ca View commit details
    Browse the repository at this point in the history

  9. Add SWIG template specialization for Some<ObservedValue>. 

    * Rename Some<ObservedValue> to SomeObservedValue
* Add also some to SGBase.i
* Guard wrap methods from SWIG
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    3056d04 View commit details
    Browse the repository at this point in the history

  10. Return ObservedValue * instead of Some<ObservedValue>. 

    This will make SWIG much happier since Some it is still not ready
to be exposed through the interfaces.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    44da1aa View commit details
    Browse the repository at this point in the history

  11. Remove PUT_ADD(ParameterObserver).

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    795366c View commit details
    Browse the repository at this point in the history

  12. Make m_fold_results available through get() and put().

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    432d637 View commit details
    Browse the repository at this point in the history

  13. Remove all getters/setters from CrossValidationFoldStorage.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    7060bcd View commit details
    Browse the repository at this point in the history

  14. Add unsubscribe() procedure to detach a parameter observer from an SG… 

    …Object.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    b4ce5b0 View commit details
    Browse the repository at this point in the history

  15. Fix failing tests.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    d18c051 View commit details
    Browse the repository at this point in the history

  16. Minor improvements.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    ac6db95 View commit details
    Browse the repository at this point in the history

  17. Again minor improvement for making ParameterObserver work with SWIG.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    a054b18 View commit details
    Browse the repository at this point in the history

  18. Fix CV unittests.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    800ebe3 View commit details
    Browse the repository at this point in the history

  19. Add unit tests to check the subscribe/unsubscribe methods. 

    * Fix again ParameterObserverCV tests;
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    e43cf29 View commit details
    Browse the repository at this point in the history

  20. Refactor unsubscribe() to implicitly store the index inside the Param… 

    …eterObserver.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    850a322 View commit details
    Browse the repository at this point in the history

  21. Add a simple ParameterObserverLogger. 

    It will print on screen all the observed values.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    b24a785 View commit details
    Browse the repository at this point in the history

  22. Fix lambda inside ParameterObserverLogger.cpp.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    86706f8 View commit details
    Browse the repository at this point in the history

  23. Apply get(name, index) to CrossValidationStorage.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    1998094 View commit details
    Browse the repository at this point in the history

  24. Fix ParameterObserverLogger when it needs to print the received values. 

    * Fix comparison warning;
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    a795318 View commit details
    Browse the repository at this point in the history

  25. Refactor CrossValidationStorage/FoldStorage such to be gettable. 

    * Fix memory error related to crossvalidation's fold results;
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    3ca3389 View commit details
    Browse the repository at this point in the history

  26. Remove m_total_subscriptions in favour of a simpler method.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    21a8efd View commit details
    Browse the repository at this point in the history

  27. Remove specialized getter from the ParameterObserver interface. 

    * Fix meta examples;
* Fix static casting issue when unsubscribing an observer;
* Refactor all CrossValidationStorage and observers to use only CEvaluationResult
  as base class;
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    242e768 View commit details
    Browse the repository at this point in the history

  28. Remove get_CV_storage from cpp target and add CLabels to the get disp… 

    …atcher.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    eaf4743 View commit details
    Browse the repository at this point in the history

  29. Fix ParameterObserverCV unit test (again).

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    0923c1e View commit details
    Browse the repository at this point in the history

  30. Fix undocumented meta examples.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    0e9c386 View commit details
    Browse the repository at this point in the history

  31. Fix SG_PRINT issue with std::string inside ParameterObserverLogger.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    93390bd View commit details
    Browse the repository at this point in the history

  32. Fix SWIG interface code for the ParameterObservers.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    cf2895e View commit details
    Browse the repository at this point in the history

  33. Refactor get(std::name, index) such to provide a non-throwing version. 

    It works more nicely with the interfaces and does not bloat the entire
terminal output with errors if it fails to cast to the corret type.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    4fe2a4c View commit details
    Browse the repository at this point in the history

  34. General fixes and improvements.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    66ff937 View commit details
    Browse the repository at this point in the history

  35. Modified ParameterObserverLogger such to not handle SGVector and SGMa… 

    …trix.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    fc61e94 View commit details
    Browse the repository at this point in the history

  36. Removed obtain_from_generic() from GradientResult and CrossValidation… 

    …Result.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    e626832 View commit details
    Browse the repository at this point in the history

  37. Fix some unit tests.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    ac47433 View commit details
    Browse the repository at this point in the history

  38. Add as_evaluation_result() such to cast CSGObject to CEvaluationResult. 

    It is needed in some languages (Java and C#).
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    661e750 View commit details
    Browse the repository at this point in the history

  39. Fix Ruby interface error caused by converters.h.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    03e47a6 View commit details
    Browse the repository at this point in the history

  40. General fixes and improvements.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    10ddda9 View commit details
    Browse the repository at this point in the history

  41. Fix undocumented cross validation example.

    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    8db46ba View commit details
    Browse the repository at this point in the history

  42. Removed operators== from CrossValidationFoldStorage and CrossValidati… 

    …onStorage.
    @geektoni
    geektoni committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    ac2ef79 View commit details
    Browse the repository at this point in the history