Here comes the new SubsetStack system #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the basic classes needed for this
bugfix in get_unique_labels (subset case)
SGVector to const SGVector&
sonney2k
pushed a commit
that referenced
this pull request
Apr 22, 2012
Implement the new SubsetStack system
sonney2k
pushed a commit
that referenced
this pull request
May 22, 2012
Implement the new SubsetStack system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every class which should have subsets now has a variable of type CSubsetStack instead of CSubset.
Its possible to add as many as you like, works like a stack
All the logic is now in the stack, so the classes (currently Features, Labels) dont have to do anything but just provide wrapper methods
The CSubset class has changed and is now a wrapper for the SGVector of indices.
Currently, all index sets are copied when a CSubset is created in CSubsetStack, however, as soon as there is ref-counting for SGVector, this should be changed.
Comments?