Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Here comes the new SubsetStack system #480

Merged
merged 23 commits into from Apr 22, 2012

Conversation

Projects
None yet
2 participants
Owner

karlnapf commented Apr 22, 2012

Every class which should have subsets now has a variable of type CSubsetStack instead of CSubset.
Its possible to add as many as you like, works like a stack
All the logic is now in the stack, so the classes (currently Features, Labels) dont have to do anything but just provide wrapper methods

The CSubset class has changed and is now a wrapper for the SGVector of indices.
Currently, all index sets are copied when a CSubset is created in CSubsetStack, however, as soon as there is ref-counting for SGVector, this should be changed.

Comments?

karlnapf added some commits Apr 21, 2012

@sonney2k sonney2k added a commit that referenced this pull request Apr 22, 2012

@sonney2k sonney2k Merge pull request #480 from karlnapf/master
Implement the new SubsetStack system
4328d97

@sonney2k sonney2k merged commit 4328d97 into shogun-toolbox:master Apr 22, 2012

@sonney2k sonney2k added a commit that referenced this pull request May 22, 2012

@sonney2k sonney2k Merge pull request #480 from karlnapf/master
Implement the new SubsetStack system
64c7a3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment