Add Vue example #11
Merged
Add Vue example #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogunpurple
requested changes
May 29, 2018
README.md
Outdated
| The examples are just as a showcase. Themeit doesn't, in any way, depend or the frameworks below. | ||
|
|
||
| ### Vue | ||
| A basic Vue example of Theme It can be found here: https://codesandbox.io/s/zz2on366jl?view=preview |
There was a problem hiding this comment.
If you could just update this to be a link to your example that would be great.
Like this - Vue
README.md
Outdated
| @@ -294,6 +296,13 @@ themeit.createThemes({ | |||
| themeit.applyTheme("nested-light-theme"); | |||
| ``` | |||
|
|
|||
| ## Examples | |||
| As a way of show casing the power of themeit we created some examples in different frameworks. | |||
| The examples are just as a showcase. Themeit doesn't, in any way, depend or the frameworks below. | |||
|
@mmckeaveney I changed the things you requested. Feel free to have another look and merge it when you feel like it's ready. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found your help wanted tag on issue here: #7
I figured to put myself on the Vue example and here is the PR related to it.
If you have any feedback on how I'm doing stuff in the example let me know.
I hope you like it. Let me know if you have any feedback. :)
I marked myself as a code contributor, but maybe this is more documentation?