Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use components from @shootismoke/ui #632

Closed
4 tasks done
amaury1093 opened this issue Jun 9, 2020 · 5 comments · Fixed by #755
Closed
4 tasks done

Use components from @shootismoke/ui #632

amaury1093 opened this issue Jun 9, 2020 · 5 comments · Fixed by #755
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@amaury1093
Copy link
Member

amaury1093 commented Jun 9, 2020 •
edited
Loading

We're working on the webapp now, so I decided to extract some components out for easy re-use, they are in https://github.com/shootismoke/common/tree/master/packages/ui.

However some components are not replaced yet inside this repo:

This issue is removing these components from this repo, and using the ones from @shootismoke/ui instead.
@amaury1093 amaury1093 added the good first issue Good for newcomers label Jun 9, 2020
@jorgerivero3
Copy link
Contributor

#680

@amaury1093 amaury1093 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 1, 2020
@lomby92
Copy link
Contributor

lomby92 commented Oct 3, 2020 •
edited
Loading

Found by searching for hacktoberfest, i will take care of replacing Button.

EDIT:
PR is here: #754
Let me know for any issue

lomby92 added a commit to lomby92/shoot-i-smoke that referenced this issue Oct 3, 2020
@lomby92
shootismoke#632: use Button component from UI library
f822fcf 
- remove Button component from project
- use shootismoke/ui Button component
@lomby92
Copy link
Contributor

lomby92 commented Oct 4, 2020

@amaurymartiny I can also do the AboutBox replacing, let me know if you are ok with this

@amaury1093
Copy link
Member Author

Yes, please, go ahead! 🙏

lomby92 added a commit to lomby92/shoot-i-smoke that referenced this issue Oct 4, 2020
@lomby92
shootismoke#632: replace AboutBox with ConversionBox from UI library
1b4e13a
@lomby92 lomby92 mentioned this issue Oct 4, 2020
Merged
@lomby92
Copy link
Contributor

lomby92 commented Oct 4, 2020

PR for ConversionBox: #755

adi-mohan added a commit to adi-mohan/shoot-i-smoke that referenced this issue Oct 21, 2020
@adi-mohan
Trying to solve flaky/failing E2E testing
7726e2d 
shootismoke#704  Trying with a set of changes pointed out in shootismoke#632
@adi-mohan adi-mohan mentioned this issue Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#632: replace AboutBox with ConversionBox from UI library lomby92/shoot-i-smoke
3 participants
@amaury1093 @lomby92 @jorgerivero3