Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Loop and Conditional extensions to the SHOP domain language #142

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Add Loop and Conditional extensions to the SHOP domain language #142

wants to merge 29 commits into from

Commits on Sep 18, 2023

  1. All recent changes but unstaged.

    @ukuter @rpgoldman
    ukuter authored and rpgoldman committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1fbbf7d View commit details
    Browse the repository at this point in the history

  2. Add a test suite for domain conditionals

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6b6166f View commit details
    Browse the repository at this point in the history

  3. Add parameters to allow disabling debug prints in loop extensions

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1e5a6a7 View commit details
    Browse the repository at this point in the history

  4. Use loop extension debug printing function in conditional extensions 

    to enable disabling debug prints.
    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1287cc4 View commit details
    Browse the repository at this point in the history

  5. Move some debug prints in explicit search behind *verbose* checks

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    0ea841a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Fix errors from rebase. 

    Fix syntax error and unused `rationale` argument.
    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    abd5f52 View commit details
    Browse the repository at this point in the history

  2. Fix undefined variable.

    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    61f246d View commit details
    Browse the repository at this point in the history

  3. Fix more rebase issues.

    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    48d23b4 View commit details
    Browse the repository at this point in the history

  4. Fix variable issues. 

    Undefined variable (misspelling) and variable that is written but not
read.
    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3be9da9 View commit details
    Browse the repository at this point in the history

  5. Remove incorrect ignore declaration.

    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    82ddd4b View commit details
    Browse the repository at this point in the history

  6. Fix two bugs in seek-plans-stack. 

    Setting up to print trace information caused us inadvertently to
rebind `state`, breaking a call to `stack-backtrack`.
    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8be565a View commit details
    Browse the repository at this point in the history

  7. Remove a condition 

    This condition is removed in the original `loop-conditional-exts`
branch and replaced with just the else condition. This change matches
the behavior on that branch.
    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1f479f9 View commit details
    Browse the repository at this point in the history

  8. Change (until (not <condition>)) to (while <condition>)

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1a93302 View commit details
    Browse the repository at this point in the history

  9. Replace slot type comments with declarations

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ea1aa06 View commit details
    Browse the repository at this point in the history

  10. Add ftype declaration to make-conditional-state-expand

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c215068 View commit details
    Browse the repository at this point in the history

  11. Fix misformed ftype definition

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    99bd64e View commit details
    Browse the repository at this point in the history

  12. Use conditional-p rather than duplicating the check directly

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d396dd1 View commit details
    Browse the repository at this point in the history

  13. Replace dbg-lp with trace-print

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    31e9772 View commit details
    Browse the repository at this point in the history

  14. Create looping-mixin

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d9951f4 View commit details
    Browse the repository at this point in the history

  15. gensym + intern replaced by gentemp 

    And a package name is provided
    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a43364f View commit details
    Browse the repository at this point in the history

  16. Fix indentation error

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bee99e1 View commit details
    Browse the repository at this point in the history

  17. Import relevant SHOP symbols into loop conditionals test package

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b7e3e96 View commit details
    Browse the repository at this point in the history

  18. Add ":redefine-ok t" to test domains in loop conditional tests

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7ddcd7b View commit details
    Browse the repository at this point in the history

  19. Fix incorrect trace print

    @mdehavensift @rpgoldman
    mdehavensift authored and rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ae9da93 View commit details
    Browse the repository at this point in the history

  20. Fix errors introduced when rebasing.

    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8d362f4 View commit details
    Browse the repository at this point in the history

  21. RANDOM-STATE update.

    @rpgoldman
    rpgoldman committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0808cde View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Replace tabs with spaces

    @matthewdehaven
    matthewdehaven committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1725030 View commit details
    Browse the repository at this point in the history

  2. Add optional package argument to new-symbol

    @matthewdehaven
    matthewdehaven committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    987376d View commit details
    Browse the repository at this point in the history

  3. Simplify seek-plans-task for looping domain 

    Only handle the loop tasks and defer primitive and non-primitive
handling to `call-next-method`. This avoids duplicate code which could
break other extensions.
    @matthewdehaven
    matthewdehaven committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1a61b7a View commit details
    Browse the repository at this point in the history