App rating feature #1125
Merged
App rating feature #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add rating feature
Carsten89
reviewed
Sep 6, 2021
- refactor the approach for the timer issue
- fine-tuning of the previous logic - debug and remove some issues - add new translations - add a new selector
- remove unused functions
- refactor
- change the selector to not check for rejection counts
Carsten89
reviewed
Sep 8, 2021
- fix rejection link
Carsten89
reviewed
Sep 8, 2021
- add app rating to gdm theme
- fix over-headed selector
Carsten89
suggested changes
Sep 8, 2021
- actions refactor
Carsten89
reviewed
Sep 13, 2021
- remove min time check from actions and use a bool const for it
Carsten89
reviewed
Sep 16, 2021
…o-rate-the-apps-in-the
…s-in-the' into CURB-1449-pop-up-to-rate-the-apps-in-the
Carsten89
reviewed
Sep 27, 2021
| // even subscriber to handle app start ratings | ||
| // and also time interval ratings | ||
| subscribe(appDidStart$, async ({ dispatch, getState }) => { | ||
| if (!bundleId || !bundleId.android || !bundleId.ios) { |
There was a problem hiding this comment.
this check is missing in the other appDidStart subscription
Carsten89
approved these changes
Sep 30, 2021
fkloes
pushed a commit
that referenced
this pull request
Apr 27, 2023
…pps-in-the App rating feature
fkloes
pushed a commit
that referenced
this pull request
Apr 27, 2023
…pps-in-the App rating feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds the app rating feature
Type of change
Please add an "x" into the option that is relevant:
How to test it
manual tests