Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back in stock feature #1211

Merged
merged 58 commits into from
Mar 1, 2024

Conversation

SaschaKrist
Copy link
Contributor

@SaschaKrist SaschaKrist commented Feb 2, 2024

Adds the "Back in Stock" Feature including a Subscription page and
action buttons on product detail pages to activate.

Description

Please include a summary of the change. Please also include relevant motivation and context.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

  • Find a product which is out of stock.
  • For parent products select a variant
  • Add a back in stock subscription for the selected product (Button should be visible under out of stock message. For Variants this button also appears in the variant picker)
  • Check if subscription is visible on "back in stock subscription" page.

@SaschaKrist SaschaKrist self-assigned this Feb 2, 2024
@SaschaKrist SaschaKrist changed the title Add back in stock Back in stock feature Feb 6, 2024
libraries/commerce/favorites/constants/Pipelines.js Outdated Show resolved Hide resolved
libraries/engage/back-in-stock/actions/index.js Outdated Show resolved Hide resolved
libraries/engage/back-in-stock/actions/index.js Outdated Show resolved Hide resolved
themes/theme-ios11/pages/subscribers.js Outdated Show resolved Hide resolved
libraries/common/constants/Portals.js Outdated Show resolved Hide resolved
libraries/commerce/product/constants/Portals.js Outdated Show resolved Hide resolved
themes/theme-gmd/locale/de-DE.json Show resolved Hide resolved
libraries/engage/back-in-stock/components/List/index.jsx Outdated Show resolved Hide resolved
libraries/engage/back-in-stock/components/List/index.jsx Outdated Show resolved Hide resolved
- improved text alignment and icon spacing
themes/theme-ios11/extension-config.json Outdated Show resolved Hide resolved
themes/theme-gmd/extension-config.json Outdated Show resolved Hide resolved
themes/theme-gmd/extension-config.json Outdated Show resolved Hide resolved
themes/theme-gmd/pages/index.jsx Outdated Show resolved Hide resolved
themes/theme-gmd/locale/de-DE.json Outdated Show resolved Hide resolved
libraries/engage/core/actions/grantPushPermissions.js Outdated Show resolved Hide resolved
libraries/engage/core/actions/grantPermissions.js Outdated Show resolved Hide resolved
libraries/engage/core/actions/grantPermissions.js Outdated Show resolved Hide resolved
showWhenAvailable={false}
className={styles.availabilityText}
/>
<BackInStockButton
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this right aligned? since it relates to the availability text, should it be aligned like that? i think at the other places where this component is used that's the case.

Bildschirmfoto 2024-02-26 um 13 42 00

changing this would give enough space at the right side to move the prices up and remove some whitespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so first it is aligned like that for no reason.
Daniel approved this version so it was fine for me but anyway i will put it to to t left side.

Anyway i dont see enough space to make it have two columns.
Also i remember you complaining about columns on mobile.

image

Copy link
Collaborator

@fkloes fkloes Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the button is misaligned within the characteristics sheet when a product is on the list
Bildschirmfoto 2024-02-29 um 08 43 22

additionally the text jumps a bit when the status changes

Bildschirmfoto 2024-02-29 um 10 01 24

@SaschaKrist
Copy link
Contributor Author

Cause of the changes from "availability" to "stock" something has changes.
Now also a not completely defined variant ( e.g. color without size) can have a "out of stock" state and therefore shows the "back in stock button"
Not sure if this is right or intended.

image

@fkloes fkloes changed the base branch from master to v6.22.0 March 1, 2024 10:30
@fkloes fkloes changed the base branch from v6.22.0 to CURB-3885-back-in-stock-feature March 1, 2024 10:55
@fkloes fkloes merged commit 181e019 into CURB-3885-back-in-stock-feature Mar 1, 2024
@fkloes fkloes deleted the CURB-3886_add_back_in_stock branch March 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants