Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are now taken from the action when requesting #318

Conversation

richardgorman
Copy link
Contributor

Description

When removing filters via the category route, the request for products now contains the current selection instead of the previous selection.

  • [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@richardgorman richardgorman added the bug Something isn't working label Oct 11, 2018
@richardgorman richardgorman self-assigned this Oct 11, 2018
@coveralls
Copy link

coveralls commented Oct 11, 2018

Pull Request Test Coverage Report for Build 1172

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/pages/Category/subscriptions.js 0 3 0.0%
Totals Coverage Status
Change from base Build 1171: 0.0%
Covered Lines: 4127
Relevant Lines: 8316

💛 - Coveralls

@fkloes fkloes merged commit 81b4064 into PWA-327-Exchange-Router Oct 12, 2018
@fkloes fkloes deleted the PWA-1099-Filter-attribute-removal-doesnt-trigger-product-update branch October 12, 2018 10:01
SG-Noxoreos pushed a commit that referenced this pull request Oct 30, 2018
…date

PWA-486: HTML widget is now rerendered when config updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants