Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The store is not re-hydrated after the initial state was already set. #321

Merged
merged 4 commits into from
Oct 12, 2018
Merged

The store is not re-hydrated after the initial state was already set. #321

merged 4 commits into from
Oct 12, 2018

Conversation

devbucket
Copy link
Contributor

Type of change

Please add an "x" into the option that is relevant:

  • [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the bug Something isn't working label Oct 12, 2018
@devbucket devbucket self-assigned this Oct 12, 2018
@coveralls
Copy link

coveralls commented Oct 12, 2018 •
edited

Pull Request Test Coverage Report for Build 1176

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 47.274%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/common/reducers/page/index.js 0 1 0.0%
libraries/common/store/index.js 4 7 57.14%
Totals Coverage Status
Change from base Build 1173: -0.01%
Covered Lines: 4129
Relevant Lines: 8322
💛 - Coveralls

@fkloes
PWA-1094: Minor changes
23630b7 
- added error handling into the page reducer
- took care that string.replace isn't executed on an empty localStorage response
@fkloes fkloes merged commit 32cdb15 into PWA-327-Exchange-Router Oct 12, 2018
@fkloes fkloes deleted the PWA-1094-Startpage-widgets-not-requested branch October 12, 2018 13:07
SG-Noxoreos pushed a commit that referenced this pull request Oct 30, 2018
@devbucket
Merge pull request #321 from shopgate/PWA-594-function-test-login
50b7e91 
PWA-594 function test login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkloes fkloes fkloes approved these changes

Assignees

@devbucket devbucket

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devbucket @coveralls @fkloes @richardgorman