-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue where the page content was overlapped by footer components #353
Fixed an issue where the page content was overlapped by footer components #353
Conversation
Pull Request Test Coverage Report for Build 1384
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take into consideration the recent changes regarding the footer contents.
…o PWA-1157-payment-bar-overlaps-cart
…age content - added ContentBelow View component logic to the AddToCartBar - updated ContentBelow component to consider page insets - fixed an GMD issue where the category content was scrollable horizontally when the FilterBar was visible
…o PWA-1157-payment-bar-overlaps-cart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using the Footer portal to inject the bar. It should remove some complexity around this PaymentBar
Putting the PaymentBar into the Footer portal would require some bigger refactoring of the component, since it's already putted into kind of a portal. Since the PaymentBar is also used within the GMD theme - other than the AddToCartBar and the TabBar - i'd also have to extend the Viewport with a footer section to keep the themes in sync. |
@@ -19,7 +19,7 @@ const content = (isFullscreen = false, keyboardHeight = 0, noScroll = false) => | |||
width: '100vw', | |||
position: 'absolute', | |||
top: 0, | |||
paddingBottom: `calc(var(--tabbar-height) + ${keyboardHeight}px + var(--safe-area-inset-bottom))`, | |||
paddingBottom: `${keyboardHeight}px`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a template string here
@@ -6,30 +6,35 @@ import variables from 'Styles/variables'; | |||
* @param {boolean} isFullscreen Whether remove all offsets, | |||
* so that it's really fullscreen (including the notch). | |||
* @param {number} keyboardHeight The space that is taken by the keyboard. | |||
* @param {boolean} noScroll Wheather the view should be scrollable or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type: whether
Description
On an iPhone X the PaymentBar and the AddToCartBar don't overlap the page content anymore when the user scrolls to the bottom of the page.
Type of change
How to test it