Fixed an issue where the page content was overlapped by footer components #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1384
💛 - Coveralls |
reneeichhorn
pushed a commit
that referenced
this pull request
Oct 31, 2018
richardgorman
suggested changes
Nov 1, 2018
…o PWA-1157-payment-bar-overlaps-cart
…age content - added ContentBelow View component logic to the AddToCartBar - updated ContentBelow component to consider page insets - fixed an GMD issue where the category content was scrollable horizontally when the FilterBar was visible
…o PWA-1157-payment-bar-overlaps-cart
richardgorman
suggested changes
Nov 5, 2018
|
Putting the PaymentBar into the Footer portal would require some bigger refactoring of the component, since it's already putted into kind of a portal. Since the PaymentBar is also used within the GMD theme - other than the AddToCartBar and the TabBar - i'd also have to extend the Viewport with a footer section to keep the themes in sync. |
| @@ -19,7 +19,7 @@ const content = (isFullscreen = false, keyboardHeight = 0, noScroll = false) => | |||
| width: '100vw', | |||
| position: 'absolute', | |||
| top: 0, | |||
| paddingBottom: `calc(var(--tabbar-height) + ${keyboardHeight}px + var(--safe-area-inset-bottom))`, | |||
| paddingBottom: `${keyboardHeight}px`, | |||
There was a problem hiding this comment.
No need for a template string here
| @@ -6,30 +6,35 @@ import variables from 'Styles/variables'; | |||
| * @param {boolean} isFullscreen Whether remove all offsets, | |||
| * so that it's really fullscreen (including the notch). | |||
| * @param {number} keyboardHeight The space that is taken by the keyboard. | |||
| * @param {boolean} noScroll Wheather the view should be scrollable or not. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On an iPhone X the PaymentBar and the AddToCartBar don't overlap the page content anymore when the user scrolls to the bottom of the page.
Type of change
How to test it