-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken InfiniteContainer process #407
Fixed broken InfiniteContainer process #407
Conversation
… InfiniteContainer
…o PWA-1282-product-list-loads-forever
@@ -0,0 +1,125 @@ | |||
import React, { Component } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we need this new component. Instead of passing the ref to this component, the consumption of the ref could happen inside the and then be passed down to the content component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See code comment
Pull Request Test Coverage Report for Build 1571
💛 - Coveralls |
…gate/pwa into PWA-1282-product-list-loads-forever
…o PWA-1282-product-list-loads-forever
Description
This ticket fixes a bug that prevented that one could open the same category multiple times in a row. It contains a refactoring of the system which is used to determine the scroll container of a page.
Type of change
How to test it
When you scroll down now, the InfiniteContainer should add the cached products