Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken InfiniteContainer process #407

Merged

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Nov 20, 2018

Description

This ticket fixes a bug that prevented that one could open the same category multiple times in a row. It contains a refactoring of the system which is used to determine the scroll container of a page.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

How to test it

  • open a category like "4. all products"
  • scroll down to get some more products
  • open the "Browse" page or pick "Categories" from the NavDrawer and select the previous opened category

When you scroll down now, the InfiniteContainer should add the cached products

@fkloes fkloes added the bug Something isn't working label Nov 20, 2018
@fkloes fkloes self-assigned this Nov 20, 2018
@@ -0,0 +1,125 @@
import React, { Component } from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we need this new component. Instead of passing the ref to this component, the consumption of the ref could happen inside the and then be passed down to the content component.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@richardgorman richardgorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code comment

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 1571

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 47.129%

Totals Coverage Status
Change from base Build 1570: -0.02%
Covered Lines: 4839
Relevant Lines: 9698

💛 - Coveralls

@richardgorman richardgorman merged commit 5bb901e into PWA-327-Exchange-Router Nov 22, 2018
@richardgorman richardgorman deleted the PWA-1282-product-list-loads-forever branch November 22, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants