Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased hit area of the cart item context menu #467

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Dec 10, 2018

Description

This ticket is about to increase the click area around the ContextMenu dots to avoid mistakenly opening cart products.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@fkloes fkloes added the bug Something isn't working label Dec 10, 2018
@fkloes fkloes self-assigned this Dec 10, 2018
@coveralls
Copy link

coveralls commented Dec 10, 2018

Pull Request Test Coverage Report for Build 1740

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 40.843%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/pages/Cart/components/Item/components/Product/components/Layout/components/Title/style.js 0 2 0.0%
themes/theme-ios11/pages/Cart/components/Item/components/Product/components/Layout/components/Title/style.js 0 2 0.0%
Totals Coverage Status
Change from base Build 1738: -0.005%
Covered Lines: 5124
Relevant Lines: 12146

💛 - Coveralls

@devbucket devbucket merged commit 2322e46 into develop Dec 10, 2018
@devbucket devbucket deleted the PWA-1291-cart-context-dots-pwa-5 branch December 10, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants