Improved layout of "no product results" pages with active filters #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1785
💛 - Coveralls |
| @@ -5,4 +5,7 @@ export default css({ | |||
| background: colors.light, | |||
| marginTop: 16, | |||
| padding: '0 16px', | |||
| ':empty': { | |||
There was a problem hiding this comment.
Maybe change this to only add the margin-top when there is content inside the element.
|
Please consider them GMD theme too |
richardgorman
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket is about removing a visual gap between the
FilterBarand the actual page content when no products match the selected filter combination.Type of change
How to test it
Goto a category with a lot of products and apply a filter combination where no products are available for. With this ticket no margin should be applied the the
ProductGridComponentwhen it's empty.