Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ellipsis for product properties in a cart view #508

Merged
merged 4 commits into from
Jan 24, 2019
Merged

Add ellipsis for product properties in a cart view #508

merged 4 commits into from
Jan 24, 2019

Conversation

alexbridge
Copy link
Contributor

@alexbridge alexbridge commented Jan 24, 2019 •
edited

Description

Add ellipsis for product properties in a cart view, truncate to 2 lines by default

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ X ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the enhancement New feature or request label Jan 24, 2019
@alexbridge alexbridge self-assigned this Jan 24, 2019
@coveralls
Copy link

coveralls commented Jan 24, 2019 •
edited

Pull Request Test Coverage Report for Build 1905

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.837%
Totals Coverage Status
Change from base Build 1902: 0.0%
Covered Lines: 4951
Relevant Lines: 9907
💛 - Coveralls

@fkloes fkloes changed the base branch from v6.1.0 to v6.X January 24, 2019 14:33
@alexbridge alexbridge changed the base branch from v6.X to v6.1.0 January 24, 2019 14:44
@fkloes fkloes changed the base branch from v6.1.0 to v6.X January 24, 2019 15:03
@fkloes fkloes merged commit e71dfcc into v6.X Jan 24, 2019
@fkloes fkloes deleted the PWA-1608 branch January 24, 2019 15:06
reneeichhorn pushed a commit that referenced this pull request Apr 24, 2020
@fkloes
Merge pull request #508 from shopgate/PWA-1608
611fa0e 
Add ellipsis for product properties in a cart view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkloes fkloes fkloes approved these changes

Assignees

@alexbridge alexbridge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexbridge @coveralls @fkloes