Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed updating of the search term on the search page #523

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Feb 5, 2019

Description

This ticket is about to fix an issue with the search feature on GMD. When a user currently tries to change the search term, the product list within the search page doesn't update as expected.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@fkloes fkloes added the bug Something isn't working label Feb 5, 2019
@fkloes fkloes self-assigned this Feb 5, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1946

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.847%

Totals Coverage Status
Change from base Build 1938: 0.0%
Covered Lines: 4954
Relevant Lines: 9911

💛 - Coveralls

@devbucket devbucket merged commit 2aa8ce6 into v6.1.0 Feb 5, 2019
@devbucket devbucket deleted the PWA-1686-search-term-cannot-be-updated branch February 5, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants